NebulousLabs / Sia

Blockchain-based marketplace for file storage. Project has moved to GitLab: https://gitlab.com/NebulousLabs/Sia
https://sia.tech
MIT License
2.71k stars 440 forks source link

Replace TestRedundancyReporting with siatest #3057

Closed ChrisSchinnerl closed 6 years ago

ChrisSchinnerl commented 6 years ago

It seems like TestRedundancyReporting contains a NDF so I'd like to move it to the siatest package. This PR depends on the siatest package changes from PR#3052.

EDIT: This also fixes a few bugs in the siatest framework I noticed while writing porting this test over.

MSevey commented 6 years ago

@ChrisSchinnerl what from #3052 are you waiting on? My PR keeps failing because of TestRedundancyReporting. This is a real chicken or the egg situation haha

DavidVorick commented 6 years ago

looks good except for the check that needs to be added to synchronizationCheck.

I like that it's +150 / -250 even though a lot of the +150 is even extending the siatest package. Means that the siatest package is a lot more powerful and doing a good job.