I think @lukechampine made a good point in #3102 and we should probably implement that change.
A user using the client library wouldn't expect that they can't pass any BlockHeigh for the endHeight in WalletTransactionsGet. So we should change walletTransactionsHandler in node/api/wallet.go to explicitly check for the -1 string and parse the number using strconv.ParUint(endheightStr, 10, 64)
I think @lukechampine made a good point in #3102 and we should probably implement that change. A user using the client library wouldn't expect that they can't pass any
BlockHeigh
for theendHeight
inWalletTransactionsGet
. So we should changewalletTransactionsHandler
innode/api/wallet.go
to explicitly check for the-1
string and parse the number usingstrconv.ParUint(endheightStr, 10, 64)