NebulousLabs / Sia

Blockchain-based marketplace for file storage. Project has moved to GitLab: https://gitlab.com/NebulousLabs/Sia
https://sia.tech
MIT License
2.71k stars 442 forks source link

Change wallet/transactions endpoint to explicitly check for -1 #3106

Closed ChrisSchinnerl closed 6 years ago

ChrisSchinnerl commented 6 years ago

I think @lukechampine made a good point in #3102 and we should probably implement that change. A user using the client library wouldn't expect that they can't pass any BlockHeigh for the endHeight in WalletTransactionsGet. So we should change walletTransactionsHandler in node/api/wallet.go to explicitly check for the -1 string and parse the number using strconv.ParUint(endheightStr, 10, 64)