Expected behavior of Renter Contract formation

NebulousLabs / Sia

Blockchain-based marketplace for file storage. Project has moved to GitLab: https://gitlab.com/NebulousLabs/Sia

https://sia.tech

MIT License

2.71k stars 440 forks source link

Expected behavior of Renter Contract formation #3119

Open MSevey opened 6 years ago

MSevey commented 6 years ago

Need to add tests to confirm contract formation and renewal happens as expected and handles remaining funds of the allowance appropriately. Looking to confirm that contracts can not allocate more money than the allowance is set for.

MSevey commented 6 years ago

Things to Test

[ ] Total some of money stored in current period contracts should not exceed the allowance
- This can be done by continually renewing contracts by spending until they fail to renew due to insufficient funds and checking against allowance funds
[ ] Investigate the fundsAvailable used in threadContractMaintenance
[ ] Confirm amount in contract makes sense as contacts are formed and renewed

MSevey commented 6 years ago

Things to Investigate

Contract Formation

How does TotalCost get determined during the formation of the contract
How does RenterFunds get determined during the formation of the contract
Look at renewAmount for contracts and how it is determined. Compare cases of high spending and low spending