search

NebulousLabs / docker-sia

The official docker image for the Sia daemon
https://sia.tech
MIT License
20 stars 1 forks source link

siad becomes unreachable if socat dies #3

Closed jkawamoto closed 4 years ago

jkawamoto commented 4 years ago

It'd be better to restart socat or exit the container.

We can check if port 9980 is working. However, since 9980 might not respond while loading, it's not easy to find whether socat dies or siad is still loading.

ro-tex commented 4 years ago

@jkawamoto thank you for the report! We're going to look into it.

ro-tex commented 4 years ago

@jkawamoto this is an interesting problem. I suggest that we address that by adding a healthcheck and marking the container as unhealthy if socat dies. This will allow us to monitor and restart the container in such cases.

In your experience, does it happen for socat to stop working properly without exiting? If so we can adjust the healthcheck logic.

jkawamoto commented 4 years ago

Thank you for adding the healthcheck.

I don't remember if socat has ever stopped working without exiting. I'll use the new healthcheck and see if it covers all cases in practice.