Closed jkawamoto closed 4 years ago
Thank you for your review. I modified Dockerfile and add the health check introduced in #8 as well.
One problem is that Alpine Linux doesn't have bash by default. I, hence, modified shebang to use OS's default shell. Is it an acceptable change? If not, I'll copy shell scripts in alpine directory so that the main image can use /usr/bin/env bash
and the alpine one can use /bin/sh
.
Email addresses and the COPY step are fixed.
As for the shell scripts, if you build with this command at the root of this repository, it should work:
$ docker build -t sia:1.4.7-alpine -f alpine/Dockerfile .
(and docker build -t sia:1.4.7-dev -f dev/Dockerfile .
, too)
It'd be nice if there are images based on Alpine Linux.