This PR switches from using the shell version of ENTRYPOINT to the exec version.
The difference between the two versions is that in the shell one the executed command is run within an instance of /bin/sh which holds PID 1. The problem is that when the container is stopped /bin/sh receives the SIGTERM signal but doesn't send it to its children. This prevents siad from performing a graceful shutdown and exposes the user to a risk of data corruption. This chances of data corruption occurring is small since all disk operations performed by siad should be ACID. Nevertheless, nothing should stop us from eliminating it completely.
This PR switches from using the shell version of ENTRYPOINT to the exec version.
The difference between the two versions is that in the shell one the executed command is run within an instance of
/bin/shwhich holdsPID 1. The problem is that when the container is stopped/bin/shreceives theSIGTERMsignal but doesn't send it to its children. This preventssiadfrom performing a graceful shutdown and exposes the user to a risk of data corruption. This chances of data corruption occurring is small since all disk operations performed bysiadshould be ACID. Nevertheless, nothing should stop us from eliminating it completely.Closes #6