search

NebulousLabs / go-skynet

An SDK for integrating Skynet into Golang applications
MIT License
16 stars 8 forks source link

Feature: generic upload & download #2

Closed cap10morgan closed 4 years ago

cap10morgan commented 4 years ago

And I added a test for and fixed walkDirectory in e110ae8.

The core feature change in a2f97fe is to support uploading things from any io.Reader instead of requiring that they already live in files on the client.

cap10morgan commented 4 years ago

I'm still planning to push a generic Download func that returns an io.Reader for the downloaded data. But let me know if there are any issues with what's in here so far.

Done in d794340.

cap10morgan commented 4 years ago

@DavidVorick Thanks for the review. I think I've addressed the main concern. Let me know if you'd like me to do anything else in here.

cap10morgan commented 4 years ago

Just curious for a status update here. Would love to un-fork if this is OK to merge. Thanks!

mrcnski commented 4 years ago

@DavidVorick ^

mrcnski commented 4 years ago

@cap10morgan Apologies for the wait. I've been working on adding tests for all the SDKs and reviewing all community contributions, yours is the last one. Just waiting for https://github.com/NebulousLabs/go-skynet/pull/7 to be merged which introduces some integration tests. (I was aware that you introduced unit tests here and didn't duplicate them.) I will merge that into this PR when its ready so that the tests can be run on your code.

mrcnski commented 4 years ago

@cap10morgan Thanks for your patience, I've merged your changes with master and pushed the changes to my branch at https://github.com/m-cat/go-skynet/tree/generic-upload-download. Can you update your PR with these changes? I wasn't able to push to your branch directly.

Your changes are excellent by the way. I updated some parts to fit our conventions and made TestWalkDirectory just walk over testdata/ instead of constructing the test directory manually.

mrcnski commented 4 years ago

Closing in favor of https://github.com/NebulousLabs/go-skynet/pull/9. I want to merge this today so I can start working on a new feature. Thanks for your contribution!