search

NebulousLabs / go-skynet

An SDK for integrating Skynet into Golang applications
MIT License
16 stars 8 forks source link

Move to client model #22

Closed mrcnski closed 4 years ago

mrcnski commented 4 years ago

Also moves URL construction to executeRequest.

See NebulousLabs/skynet-docs#16

mrcnski commented 4 years ago

@MSevey

Didn't we add that in specifically to encourage easier third party contributions? Are we removing it because it all needs to change?

@DavidVorick wants the SDKs for now to be user-oriented, and not the admin-oriented API. I figure it's fine to remove the admin stuff because no one's actually contributed or shown interest in those APIs. We also still have plenty of missing options that the community can contribute to.

Is that to be consistent with the other SDKs? For Go Metadata would be more idiomatic and implies that you are getting the metadata.

You're right, I can make the change. It was for consistency since getMetadata is more idiomatic in JS and Python, but we prefer for users of each SDK to feel like they're writing idiomatic code -- users of e.g. the Go SDK don't care what the functions are called in Python.