NebulousLabs / hdkey

Hierarchical Deterministic Key Derivation for arbitrary secp256k1 key pairs
MIT License
7 stars 9 forks source link

Consider adding additional unit tests from peripheral Schnorr library #2

Open cjepson opened 8 years ago

cjepson commented 8 years ago

We have a further library of tests for secp256k1 Schnorr signatures that you may wish to port and use to test your code.

https://github.com/decred/dcrd/tree/master/dcrec/secp256k1/schnorr

The library could use more testing and feedback as well.

DavidVorick commented 8 years ago

we're planning on adding schorr at some point, but I don't think it's very near on our priorities list.

Bit confusing to see a file called 'ecdsa.go` in a schnorr library.

DavidVorick commented 8 years ago

ah forgot which repo I'm in. Glad to see other people are finding it

cjepson commented 8 years ago

We used "ecdsa.go" in each of the Schnorr libraries to refer simply to elliptical curve digital signature algorithms, but I can see how that could be confusing. The cleanup of these Schnorr libraries in Decred is an eventual goal. There is too an Ed25519 library that you might find useful for tests and multisignature.

https://github.com/decred/dcrd/tree/master/dcrec/edwards