search

NebulousLabs / nodejs-skynet

Library for integrating Skynet into Node.js applications
MIT License
29 stars 12 forks source link

Add function stubs #36

Closed mrcnski closed 4 years ago

mrcnski commented 4 years ago

Integration tests should be in a separate tests directory to ensure that everything was exported properly.

Add function stubs

kwypchlo commented 4 years ago

actually it's pretty common to keep the test files next to the source files, why would we want to move them out?

mrcnski commented 4 years ago

@kwypchlo I'm used to unit tests being in the same directory and integration tests being in a different directory. Otherwise, having integration tests in the same directory makes it easy to use something that wasn't actually exported. Maybe it's not common practice in JS though

kwypchlo commented 4 years ago

@m-cat actually those are all unit tests, dependencies are mocked and they test only the actual logic.

mrcnski commented 4 years ago

@kwypchlo Undid the change and added function stubs in this PR