search

NebulousLabs / python-skynet

Library for integrating Skynet with Python applications
MIT License
19 stars 11 forks source link

Simple changes to add timeout #26

Closed xloem closed 4 years ago

xloem commented 4 years ago

This change is backwards compatible and plugs the edge cases where python requests may hang forever waiting for a reply.

I've moved the timeout parameter into the opts object as recommended in a different PR. I added checks to keep the changes backwards compatible.

These are just my local changes. I have not reviewed #20 to see whether it is a better solution than this.

mrcnski commented 4 years ago

Hey @xloem, great changes. There are things I like in both your PRs, but as they are quite similar I'd be inclined to pick #20 as it's more comprehensive. I'll add a couple comments there to make sure the good parts of this PR make it through as well.