Example API calls for finnhub.io, improve azure-pipelines

Necktschnagge / finn

0 stars 0 forks source link

Example API calls for finnhub.io, improve azure-pipelines #11

Closed Necktschnagge closed 2 years ago

Necktschnagge commented 2 years ago

@r0ost3r Before you try again to get your finnhub.io requests to work:

Discard all your changes so far (or stash them locally)
Update this branch! git pull
re-enter your API Key into file src/secrets.h (Note!: If you just don't set a secret the whole program should work. Only there will be no data in summary.json)
make sure you delete any summary.json created previously
just build and run, it should work.

Necktschnagge commented 2 years ago

I've just made some additional requests which tidy up code a little bit.

Necktschnagge commented 2 years ago

Before fb80114 the application indeed crashed if there was no summary.json already created before app start.

Necktschnagge commented 2 years ago

TODOs:

add some other relevant API endpoints to finnhub_rest_client

Necktschnagge commented 2 years ago

DONE

[x] All requests are nearly copy-paste. Should introduce some fascade pattern...
[x] Also every request should run through an api limit exceed checker like stated here: #15

Necktschnagge commented 2 years ago

I just renamed the get requests of finnhub_rest_client so that the are equal to the section headers of the API documentation https://finnhub.io/docs/api/company-profile2

Necktschnagge commented 2 years ago

The runtime check is weird. We should introduce a API retry limit given to finn client on construction. The server routine then can finish within a few minutes.

Necktschnagge commented 2 years ago

Minor, pedantic improvement requests will be moved into follow-up issues!