Necoro / feed2imap-go

A software to convert rss feeds into mails.
GNU General Public License v2.0
53 stars 7 forks source link

Feature Request: Modify template #66

Closed snipem closed 2 years ago

snipem commented 2 years ago

Is there an option to disable the grey boxed meta data?

image

Otherwise, great work. I was maintaining my own fork of "feeds2imap-go" for the past years but it stopped working and the IMAP functionality was very spotty. Is it related in any way? I added readability support for non-full feeds, which would be nice in your work too.

Necoro commented 2 years ago

Hah, never knew about feeds2imap-go. Well, there are only so many possible names ;).

I think, adding an option for disabling the grey boxes is somewhat strange. I'd prefer to allow specifying one's own template. Until I've added such a feature, do not hesitate to just patch internal/feed/template/html.tpl

I added readability support for non-full feeds

What do you mean by that?

which would be nice in your work too.

I'll take pull requests :)

snipem commented 2 years ago

See this for readability: https://github.com/go-shiori/go-readability

It scrapes a website for value content only and removes all the clutter. This can be used in some instances to turn a feed with preview content only into a full feed.

Necoro commented 2 years ago

See this for readability: https://github.com/go-shiori/go-readability

It scrapes a website for value content only and removes all the clutter. This can be used in some instances to turn a feed with preview content only into a full feed.

I opened a separate request for that: #67

snipem commented 2 years ago

It would be nice to change the template without recompiling and forking.

Necoro commented 2 years ago

That is the target, eventually. Changing the compiled template in a fork is an intermediate quick solution until that feature has been implemented :)

Implementation should not be that hard, but I'm pretty sure I won't have the time this weekend.

snipem commented 2 years ago

No hurry, if I ever change something to the code I will do a push request. Templates is of no priority to me. I will look into the tool if it is working as expected in the mean time.

Schönes Wochenende!

Necoro commented 2 years ago

Implemented