search

NedaaDevs / nedaa

Muslims prayer times app in Flutter
3 stars 1 forks source link

NEDA-78-analytics-option #44

Closed F2had closed 1 year ago

F2had commented 1 year ago

Add an option to enable/disable crash logs analytics Reduce Sentry logging rate

Amjad50 commented 1 year ago

Btw, when this setting is changed, it won't apply until next rerun of the app. Since it's used in main outside the Bloc scope, so not sure if we should mention this in the settings. Otherwise all good

F2had commented 1 year ago

Btw, when this setting is changed, it won't apply until next rerun of the app. Since it's used in main outside the Bloc scope, so not sure if we should mention this in the settings. Otherwise all good

Hmm true, this is what I can think of. I don't think it'll be an issue since it's unlikely that something happens very soon (at least I hope). We can add an alert on toggle to indicate that the app needs to restart for the changes to take effect. If you a different approach on mind let me know please.

Amjad50 commented 1 year ago

Yeah I agree we should add alert, this is the best approach we have now