search

NedaaDevs / nedaa

Muslims prayer times app in Flutter
3 stars 1 forks source link

Added periodic task scheduling for iOS in Workmanager #53

Open burhanaksendir opened 3 weeks ago

F2had commented 3 weeks ago

@burhanaksendir Would you please run dart format . &flutter analyze for the CI to continue

burhanaksendir commented 3 weeks ago

@burhanaksendir Would you please run dart format . &flutter analyze for the CI to continue

I have run dart format . and flutter analyze, and updated the main.dart file accordingly.

Amjad50 commented 3 weeks ago

Hello @burhanaksendir , this is an interesting change, so looks like workmanager library added functionality to support ios background tasks.

Though, I do not prefer using the git version of the library, is there a reason this hasn't been released as a new version (eg 0.5.3 or 0.6.0)? If there is none, can we push them to release a new version?

burhanaksendir commented 3 weeks ago

Hello @burhanaksendir , this is an interesting change, so looks like workmanager library added functionality to support ios background tasks.

Though, I do not prefer using the git version of the library, is there a reason this hasn't been released as a new version (eg 0.5.3 or 0.6.0)? If there is none, can we push them to release a new version?

Hello @Amjad50, the reason I am using the git version is because it supports periodic tasks for iOS. In the normal version, only the registerOneOffTask feature is available for iOS. However, with this git version, we can run background tasks periodically on iOS just like we do on Android.

Amjad50 commented 3 weeks ago

I understand the benefit and I like it.

My question was "is there a reason this hasn't been released as a new version (eg 0.5.3 or 0.6.0)? If there is none, can we push them to release a new version?"

But, I guess we can merge this now, and change the version once they release it.

F2had commented 3 weeks ago

@burhanaksendir Sorry can you add the latest changes on the master to your pr. I made some fixes on the CI

burhanaksendir commented 3 weeks ago

I understand the benefit and I like it.

My question was "is there a reason this hasn't been released as a new version (eg 0.5.3 or 0.6.0)? If there is none, can we push them to release a new version?"

But, I guess we can merge this now, and change the version once they release it.

Yes, we can request a new version to be released. I don't know why a new version hasn't been released, but you can check the commit details here. Unfortunately, I could only run the periodic task for iOS with this ref. https://github.com/fluttercommunity/flutter_workmanager/commit/b783000c18f6e066f3d81d5ecc352f3ce61860f6

F2had commented 3 weeks ago

Hi, I have added the latest changes from the master branch to my PR. Please review it again. Thank you!

Just checked it doesn’t seems like your pr is up to date with master. Can you please double check