Nedramrez / portfolio

My portfolio is the easiest way of showing what I'm truly capable of as a developer.
5 stars 0 forks source link

Refactoring HTML #4

Open peterdtitan opened 2 years ago

peterdtitan commented 2 years ago

I suggest a few changes be made to your HTML code. The following can be considered:

  1. Using semantic tags in HTML
  2. Proper indentation.

[optional]

IamYunusAli commented 2 years ago

Line 49 includes the images in the headline section

<section>
        <img class="header-shapes" src="assets/bg.png" alt="header-shapes">
        <img class="header-background" src="assets/header-background-mobile.svg" alt="background-image">
</section>

Avoid using div inside li tag

                  <li class="tag-html">>
                      <p>html</p>
                  </li>
                  <li class="tag-css">  
                      <p>css</p>
                  </li>
                  <li class="tag-js">
                      <p>javaScript</p>
                  </li>

use section for the headline, works, about

use nav in the header, your logo have to be a link

<header>
<a href="">
              <span>My Logo</span>
</a>
<nav>
            <img class="burger" src="assets/burger.svg" alt="Menu icon.">
</nav>
</header>
Nedramrez commented 2 years ago

Yunus Linters - Excessive divs. Nav bar - Header

MxoDevops commented 2 years ago

Include nav for the nav bar on the header. Use section for homepage, projects, and about me section The logo must be a link