search

Needlworks / Textcube

Textcube : Brand yourself! / Personalized web publishing platform with multi-user support
http://www.textcube.org
Other
207 stars 55 forks source link

Fix difference of imageblock caption HTML structure on mobile #1853

Closed zvuc closed 7 years ago

zvuc commented 7 years ago

Until now, when viewing a page in a browser with mobile user agent (iPhone), imageblock captions have been displaying as a div under the imageblock div, when normal desktop views have been rendering it as <p class="cap1"> being inside the imageblock div tag.

Commit a14ac491518d48e94dba8c8a1ef9410eacdfbb38 has fixed the issue where mobile doesn't add cap1 class that is required for it to be styled correctly, but because of structure differences if existing skins were targeting .imageblock .cap1 for example, style would still look broken.

Also, because the commit has been made on master branch, old 1.10 branch still hasn't received this fix. This pull request cherry-picks the former commit to 1.10 branch and makes changes to HTML output part of ttml.php to make it output same code on mobile as it is on desktop.

inureyes commented 7 years ago

Thanks! Sorry for late check during lunar year holiday.