Negodya1 / Create-Vintage-Improvements

Some machines & compats
Other
7 stars 7 forks source link

Recipe JSON format suggestions #30

Open omgimanerd opened 4 months ago

omgimanerd commented 4 months ago

Hi! I'm a modpack dev and I'm working on adapters to the recipe JSONs so I can write the recipes using KubeJS.

I have two suggestions for the recipe types.

For the vintageimprovements:curving recipe type, there can either be a mode: [0, 1, 2] or and itemAsHead key. I suggest getting rid of mode. This is a fairly minor complaint because custom recipes can just specify itemAsHead, since knowing what mode corresponds to which built-in curving head requires you to look through the code. This only matters because custom kubejs recipe schemas need to know the mode argument is.

For the vintageimprovements:pressurizing recipe types, secondaryFluidResults and secondaryFluidInputs are optional keys but they take an index as an argument. This is a little strange and unintuitive, and I think if you made them take a fluid object json as argument and generated the index yourself internally, it would be a little more developer friendly.

Anyway, thanks so much for developing this mod! It's a great platform to build off of and the machines look great!