search

Neha-5678 / pe

0 stars 0 forks source link

Inaccurate error message for find command #5

Open Neha-5678 opened 2 years ago

Neha-5678 commented 2 years ago

Screenshot 2021-11-12 at 4.56.01 PM.png I believe that this command should provide an error message saying invalid command format and show an example of the correct command because i typed 2 dollar signs instead of 1 which does not match the command format. Instead, it says that 0 properties are listed when there are actually 15 properties that are supposed to be listed if the command were to be typed correctly as shown in the image below.

Screenshot 2021-11-12 at 4.56.21 PM.png

nus-pe-bot commented 2 years ago

Team's Response

find property $$min/10000 is a valid command as $$min/10000 is treated as a keyword search, since it does not follow any of the whitelisted prefixes $min/, $max/, t/.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I think this is still a bug because it may cause some confusion to the users if they failed to realised the typo mistake they made in the tag ($$min/ instead of $min/). They may be wondering why there are no properties listed though there are properties in the application with at least a value of $10000. There should be some error handling and a message shown to users to notify them that they have typed an invalid tag to search for.