NehemiahK / fun-react-lib

A fun React Library for practice
https://nehemiahk.github.io/fun-react-lib/
61 stars 24 forks source link

Consistent Type system across the lib #18

Open madhuni opened 4 years ago

madhuni commented 4 years ago

We should not be using random font-sizes across the lib. Let's follow consistent typography.

For a reference, we can implement typography rules proposed by Material design.

NehemiahK commented 4 years ago

Very true. Good point. This should go in the App.css file

madhuni commented 4 years ago

Or maybe we can breakdown the whole Global CSS to different subfiles. Like for Typography we can have _typography.css file. And similarly, for Layouts we can have _layout.css.

I would highly recommend using SCSS. It will allow us to make the more scalable CSS architecture.

NehemiahK commented 4 years ago

I only used CSS since I felt it was very easy to get going. Would you want to do a refactor for implementing this?

madhuni commented 4 years ago

I can do that. SCSS is a superset of CSS, everything you will write in CSS will still be valid in SCSS. Let's implement that, it will be new learning. WDYT?

I can set up the whole CSS system for the lib.

NehemiahK commented 4 years ago

Sounds good

krissh-the-dev commented 4 years ago

I suggest to go with type faces used in GitHub (use default font of all the operating systems). This way we can reduce import cost resulting in better and faster performance.

krissh-the-dev commented 4 years ago

@madhuni lets define a typeface to use throughout the project. You're up for that?

madhuni commented 4 years ago

@KrishnaMoorthy12, yeah sure. I am up for that. We can do that.