Open madhuni opened 4 years ago
Very true. Good point. This should go in the App.css file
Or maybe we can breakdown the whole Global CSS to different subfiles. Like for Typography
we can have _typography.css
file. And similarly, for Layouts
we can have _layout.css
.
I would highly recommend using SCSS
. It will allow us to make the more scalable CSS architecture.
I only used CSS since I felt it was very easy to get going. Would you want to do a refactor for implementing this?
I can do that. SCSS is a superset of CSS, everything you will write in CSS will still be valid in SCSS. Let's implement that, it will be new learning. WDYT?
I can set up the whole CSS system for the lib.
Sounds good
I suggest to go with type faces used in GitHub (use default font of all the operating systems). This way we can reduce import cost resulting in better and faster performance.
@madhuni lets define a typeface to use throughout the project. You're up for that?
@KrishnaMoorthy12, yeah sure. I am up for that. We can do that.
We should not be using random font-sizes across the lib. Let's follow consistent typography.
For a reference, we can implement typography rules proposed by Material design.