NehemiahK / fun-react-lib

A fun React Library for practice
https://nehemiahk.github.io/fun-react-lib/
61 stars 24 forks source link

Restructure README.md file to contain more contribution details #40

Open kaf-lamed-beyt opened 4 years ago

kaf-lamed-beyt commented 4 years ago

The documentation should guide developers on how to go about the project files and the styling usage. i.eusing prettier where necessary to format code before pushing to the remote repository.

NehemiahK commented 4 years ago

This is a very good point. Thank you

kaf-lamed-beyt commented 4 years ago

You're welcome :)

madhuni commented 4 years ago

@Caleb335, I am going to add the pre-commit and pre-push hooks to the repo. This will make sure that whenever anyone is going to push the code or even add a new commit, the code is formatted properly, and linting checks are done.

This part will be covered in issue #37. So I will update the document with the proper instructions.

kaf-lamed-beyt commented 4 years ago

That's great!

Thank you 😊

On Thu, 2 Jul 2020, 1:17 PM Kanishka Mohan Madhuni, < notifications@github.com> wrote:

@Caleb335 https://github.com/Caleb335, I am going to add the pre-commit and pre-push hooks to the repo. This will make sure that whenever anyone is going to push the code or even add a new commit, the code is formatted properly, and linting checks are done.

This part will be covered in issue #37 https://github.com/NehemiahK/fun-react-lib/issues/37. So I will update the document with the proper instructions.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NehemiahK/fun-react-lib/issues/40#issuecomment-652971198, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALPFZWVKBQOAD5AT7H4RCVTRZR3ETANCNFSM4ONM46LQ .

madhuni commented 4 years ago

@Caleb335, I am going to add the pre-commit and pre-push hooks to the repo. This will make sure that whenever anyone is going to push the code or even add a new commit, the code is formatted properly, and linting checks are done.

This part will be covered in issue #37. So I will update the document with the proper instructions.

This is done as part of PR #49.