search

NehemiahK / fun-react-lib

A fun React Library for practice
https://nehemiahk.github.io/fun-react-lib/
61 stars 24 forks source link

[FIX] demo layout issue fixed. progress bar added in to demo list #43

Open kvraamkey opened 4 years ago

kvraamkey commented 4 years ago

can some one add pre commit hooks in package.json file. so before commit it'll check all code formats .

madhuni commented 4 years ago

@kvraamkey I am working on that already. Issue #37.

I will raise the PR soon.

kvraamkey commented 4 years ago

Thanks @madhuni and also we need to look on layout document instructions also. Because right now i ket auto pick from folder. Based upon this we need to do.

madhuni commented 4 years ago

@kvraamkey, sorry but I didn't understand what's the point you are raising here. Can you explain it in more detail? Maybe it's my fault that I am not aware of the point you are talking about.

kvraamkey commented 4 years ago

Yep, some one added navbar on top. But it was not the correct one. So i fixed those and raised PR

kvraamkey commented 4 years ago

@kvraamkey, sorry but I didn't understand what's the point you are raising here. Can you explain it in more detail? Maybe it's my fault that I am not aware of the point you are talking about.

https://github.com/NehemiahK/fun-react-lib/issues/42#issuecomment-653726032

madhuni commented 4 years ago

@kvraamkey, let's wait for PR #49 to get merged first before we merge this PR. For more details please refer to my comment.