NeighborhoodInfoDC / General

General purpose data sets and formats
0 stars 0 forks source link

update macros #111

Closed eburton9 closed 3 years ago

eburton9 commented 3 years ago

@rpitingolo I went ahead and committed the updates, but I know you were going to show me how to test them. Thanks!

rpitingolo commented 3 years ago

@eburton9 thanks! I'll take a look at these then show you how to test.

rpitingolo commented 3 years ago

@eburton9 here is some code you can use to test. You can open a blank SAS program and paste it in there.

%include "\\sas1\DCdata\SAS\Inc\StdLocal.sas";

data test;
    set general.Geoblk2020;
    if state = '11';
    %Block20_to_ward12;
run;

proc freq data = test;
    tables ward2012;
run;

You will need to change the macro (ie Block20_to_ward12) and then in the proc freq you will need to change the name of the variable you are checking (in this example ward2012). When you run the frequency you want to make sure that 1. it runs and 2. that the format is correctly applied. Please let me know if you have questions!

eburton9 commented 3 years ago

@rpitingolo I tested all the macros and for bg 20, bpk, tr00, tr10, and vp12 I was getting an error that the variable was not found and then for psa12 there was only one psa row given in the output, I didn't know if that was right.

rpitingolo commented 3 years ago

@eburton9 thanks. I'll take a look at the ones you had errors on.

rpitingolo commented 3 years ago

@eburton9 OK all looks good. I didn't bump into the same variable not found errors as you on some of them. Maybe you had the variable name wrong? The correct variable names are geobg2020, bridgepk, geo2000, geo2010, and voterpre2012. The psa12 issue was causes by a problem with the format that I had to fix in a separate bugfix issue but that resolved it.

So please double check all of those and then you can merge this branch. Since these are all macros there is nothing to batch submit.

If you get a merge conflict because of the edits I made on the other branch let me know and I can help you resolve it.