search

NeighborhoodInfoDC / General

General purpose data sets and formats
0 stars 0 forks source link

TR and BG weights for metro area #37

Closed rpitingolo closed 6 years ago

rpitingolo commented 6 years ago

@lhendey can you please review since @ptatian is out?

ptatian commented 6 years ago

@lhendey @rpitingolo I can review.

rpitingolo commented 6 years ago

@ptatian @lhendey thanks, Peter.

rpitingolo commented 6 years ago

@ptatian in case you didn't get a notification for my comment on the commit, can you please review geo2010.sas ? Thanks.

ptatian commented 6 years ago

@rpitingolo Yes, I got the message. Reviewing Geo2010.sas now.

ptatian commented 6 years ago

@rpitingolo You should include the county # in the label for MD, VA, and WV tracts. Otherwise seems OK.

rpitingolo commented 6 years ago

@ptatian sorry I'm not following. Which variable are you referring to as the label in this case?

ptatian commented 6 years ago

@rpitingolo Actually, upon further review, you have some problem with overlapping ranges. (I tested by temporarily changing the format and data set libraries to WORK.)

ERROR: For format $GEO10OS, this range is repeated, or values overlap: 000100-000100.

ERROR: For format $GEO10DS, this range is repeated, or values overlap: 1-1.
ptatian commented 6 years ago

@rpitingolo Formats geo10so, geo10os, geo10sd, and geo10ds should be kept as DC only. These are specific to the older OCTO shapefiles and how they reference tract numbers. That will solve the overlapping range problem.

ptatian commented 6 years ago

@rpitingolo In $geo10a, the label is set to the _tractnum variable.

tract_num = 'MD Tract ' || tract4_2

You need to add the county ID into that string.

rpitingolo commented 6 years ago

@ptatian OK, I understand now. Should I do this for all 4? Or leave DC without the county? If we change DC it could create inconsistency with data produced under the current format. If we don't change then it's inconsistent within the format. Please advise.

ptatian commented 6 years ago

@rpitingolo This format is just for display, so I think it makes sense to leave the county off for DC. It isn't needed.

rpitingolo commented 6 years ago

@ptatian thanks. Made that change and moving on to the other programs.

rpitingolo commented 6 years ago

@ptatian can you please review the remaining programs I committed in general/prog.

ptatian commented 6 years ago

@rpitingolo OK, I'll take a look.

ptatian commented 6 years ago

Thanks, @rpitingolo. This looks good. I would just suggest adding a blank space between the county number and the tract number for better readability.

rpitingolo commented 6 years ago

@ptatian Good suggestion. Thanks.