NeighborhoodInfoDC / RegHsg

Regional Housing Framework
1 stars 1 forks source link

Created Preservation database program #22

Closed Woliver01 closed 5 years ago

Woliver01 commented 5 years ago

@lhendey I cleaned up the missing county codes. One of them did not have a county code, not sure if I should drop it or not.

lhendey commented 5 years ago

@Woliver01 - is there any code book or something from the NPD that you can download to help with the labels?

Woliver01 commented 5 years ago

@lhendey this link is somewhat helpful: http://preservationdatabase.org/wp-content/uploads/2017/09/Data-Dictionary.pdf . It has codebooks throughout. I've done most of the changes you requested and I'm working on the labels now and doing proc summaries for the subsidized property locations, how many units, and expiration dates. I'll commit something later today before COB.

Woliver01 commented 5 years ago

@lhendey The link I used didn't have all of the labels but I expanded the character variables which helped with most of the variables. I also ran into some errors with the finalizing code.

lhendey commented 5 years ago

@Woliver01 is this ready for review?

Woliver01 commented 5 years ago

@lhendey please review. There was an error in the finalize macro section. I removed the revisions line after I committed this program but the error still showed up. "ERROR: All positional parameters must precede keyword parameters."

Woliver01 commented 5 years ago

@lhendey I figured it out I think, I committed an updated program where the error doesn't show up.

lhendey commented 5 years ago

@Woliver01 thanks. I'm looking at this now.

lhendey commented 5 years ago

@Woliver01 - if you can please try to wrap this up today @ptatian will provide some direction on the next steps for the analysis. @maggiesu0725

Woliver01 commented 5 years ago

@lhendey Will do, finishing up the labels now.

Woliver01 commented 5 years ago

@lhendey just committed the labels and other changes. Please review.

Woliver01 commented 5 years ago

@lhendey Please review changes.