search

Neilblaze / Anyxz

Ez Video Background Semantic Segmentation
https://anyxz.vercel.app
MIT License
6 stars 11 forks source link

Solving issue:Add a share widget to the Project site #14 #24

Closed KerinPithawala closed 3 years ago

KerinPithawala commented 3 years ago
  1. Added sharing widgets of 3 social media: Facebook, Twitter and LinkedIn.
  2. The URL of website: https://anyxz.vercel.app/ will be shared on these handles when user clicks on icons.

Before: image

After: image

This contribution is part of NWoC. Please review my pull request.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/fireblaze/anyxz/lu2nwlccy
✅ Preview: https://anyxz-git-kerin.fireblaze.vercel.app

Neilblaze commented 3 years ago

Thanks for contributing @Kerveyfelix . But it needs a bit of aesthetic revamp. Can you make it like this?

KerinPithawala commented 3 years ago

@Neilblaze Sure. I am researching how to do so.

KerinPithawala commented 3 years ago

Does this sharing widget look good? I couldn't make sharing like the one you shared for reference. image

Neilblaze commented 3 years ago

Umm, like I believe it's consuming a lot of space over the hero section of the page. Choose a different design, a compact one.

KerinPithawala commented 3 years ago

image This will work?

Neilblaze commented 3 years ago

I appreciate your hard work, but this isn't looking that great. Well, for now, you can do one thing, stack those social icons vertically & shift it to the left.

KerinPithawala commented 3 years ago

Sure. I am shifting the buttons to left and vertically arranging them as shown in the picture shared by you. Actually I am not able to display buttons on the left side of that green color box. The buttons wherever, I pasted them are taking up entire horizontal axis.

image Should I push this to the repo?

Neilblaze commented 3 years ago

Can you upstream this branch & then show me the status, please?

KerinPithawala commented 3 years ago

Yes, I am trying to resolve the conflicts.

Neilblaze commented 3 years ago

Thank you @Kerveyfelix! Looks great, but just a tiny change is required before I merge your PR. All of the social icons need an upward shift inside those share buttons & also add a lil bit of space between those buttons, & you're good to go!

KerinPithawala commented 3 years ago

image This works?

Neilblaze commented 3 years ago

@Kerveyfelix yup that looks better!

KerinPithawala commented 3 years ago

I have pushed the changes.

Neilblaze commented 3 years ago

@all-contributors please add @Kerveyfelix for code

allcontributors[bot] commented 3 years ago

@Neilblaze

I've put up a pull request to add @Kerveyfelix! :tada: