search

Neilblaze / Anyxz

Ez Video Background Semantic Segmentation
https://anyxz.vercel.app
MIT License
6 stars 11 forks source link

Making website PWA #25

Closed KerinPithawala closed 3 years ago

KerinPithawala commented 3 years ago

Please review the PR.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/fireblaze/anyxz/hz6fg1ctc
✅ Preview: https://anyxz-git-k2.fireblaze.vercel.app

Neilblaze commented 3 years ago

@Kerveyfelix thanks for contributing. But according to the rules & regulations we can't accept a single PR for two different issues.

Moreover, the share widget needs to be updated as I showed over here. Similar design inspirations are also welcome!

And last but not the least, the service worker is invalid. Returns fetch errors. I've gone through your PR commit & it's quite distinct that the service worker has wrong scopes assigned to it with invalid param routes.

Kindly check & re-raise the PR. Make sure to follow this. If getting stuck, feel free to discuss your issue on the Anyxz Gitter channel.

KerinPithawala commented 3 years ago

@Neilblaze Thanks for the feedback. I will have different pull requests for different issues. Currently working on share buttons better design. Will need some time to debug the errors of the service worker.

Neilblaze commented 3 years ago

Sure, take your time!