search

Neilblaze / Anyxz

Ez Video Background Semantic Segmentation
https://anyxz.vercel.app
MIT License
6 stars 11 forks source link

Removed Google + button #43

Closed Pranav016 closed 3 years ago

Pranav016 commented 3 years ago

This PR was made under NWoC

What is the change?

Removed the google + button

What does it fix/add?

Solves #42

How was it tested?

On local host

Submissions guide:

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/fireblaze/anyxz/nc65fa2z9
✅ Preview: https://anyxz-git-fork-pranav016-google.fireblaze.vercel.app

Pranav016 commented 3 years ago

This PR was made under NWoC

What is the change?

Removed the google + button

What does it fix/add?

Solves #42

How was it tested?

On local host

Submissions guide:

  • [x] Have you followed the Contribution guide?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x] Have you made corresponding changes to the documentation?
  • [x] Your submission doesn't break any existing feature.
  • [x] Have you lint your code locally prior to submission?

Good to merge? 😀 @Neilblaze

Neilblaze commented 3 years ago

Upstream the repo and then create the PR from a separate branch. I'm getting responsiveness issues.

Pranav016 commented 3 years ago

Upstream the repo and then create the PR from a separate branch. I'm getting responsiveness issues.

That's exactly what I did, made the PR from a new branch. Can you check again on a new browser/ device? Shouldn't give any issues though, otherwise I'll make a new PR

Neilblaze commented 3 years ago

Upstream the repo and then create the PR from a separate branch. I'm getting responsiveness issues.

That's exactly what I did, made the PR from a new branch. Can you check again on a new browser/ device? Shouldn't give any issues though, otherwise I'll make a new PR

You made the PR from another branch that's well & good, but did you upstream it?

Pranav016 commented 3 years ago

Upstream the repo and then create the PR from a separate branch. I'm getting responsiveness issues.

That's exactly what I did, made the PR from a new branch. Can you check again on a new browser/ device? Shouldn't give any issues though, otherwise I'll make a new PR

You made the PR from another branch that's well & good, but did you upstream it?

Did you mean pull from uptream? Then yes I updated my master before branching

Pranav016 commented 3 years ago

I just checked on multiple devices, the currently deployed website and the one after my PR. I think the PR hasn't had any effect on responsiveness, looks the same to me, just the icon is removed! :p

Neilblaze commented 3 years ago

@Pranav016 do the upstream first, then raise the pr. Else you're good to go :+1: