search

NejcZdovc / ng2-select2

Select 2 wraper for angular2
MIT License
123 stars 93 forks source link

angular 4 #99

Open rocherR opened 7 years ago

rocherR commented 7 years ago

Hi, is working for angular 4 ? in my case select2 is not rocognized

sh977218 commented 7 years ago

I'm using angular 4.1.3 and it seems they are compatible so far.

ghost commented 7 years ago

However ng2-select2 has defined angular/core^2.2.0 as a peer dependency, it works with angular/core 4 and up. I'm using angular 4.3.5 without any problem.

I'm wondering if this repo is still maintained. It's still in beta...

sh977218 commented 7 years ago

I believe nodeJS > 8 will take care the peer dependency. Since it will modify shrinkwrap file for all dependencies if there is shrinkwrap when npm install.

fabricionogueira commented 7 years ago

My npm install did not work with angular 4

acoard commented 7 years ago

The second to last commit to this project was on May 14th, when they updated the peer dependency. Are the maintainer still active? All they need to do is bump the version # again.

I can confirm that ng2-select2 works fine on an angular4 project. Literally all that's required is changing package.json.

Working project version info:

@angular/cli: 1.1.3
node: 7.6.0
os: darwin x64
@angular/common: 4.2.4
@angular/compiler: 4.2.4
@angular/compiler-cli: 4.2.4
@angular/core: 4.2.4
@angular/forms: 4.2.4
@angular/http: 4.2.4
@angular/platform-browser: 4.2.4
@angular/platform-browser-dynamic: 4.2.4
@angular/router: 4.2.4
@angular/cli: 1.1.3

This is a great project, and it's a shame it's literally the only one I'm working with that throws a warning on install.