Peer to peer Review October 14th, 2022

Nejjari001 / To-Do-List-List-structure

"To-do list" This project is a simple To-Do List application built using JavaScript. The user can add tasks to the list by entering the task description in an input field and clicking the "Add" button. Clicking on a task in the list marks it as done with a line-through effect, and clicking again will remove the line-through to indicate completion.

1 stars 0 forks source link

Peer to peer Review October 14th, 2022 #8

Closed Olivier-Kango closed 2 years ago

Olivier-Kango commented 2 years ago

Hi @Nejjari001,

Good job 👏

There are some issues that you still need to work on!

tenor

Highlights

✅ Correct use of GitHub workflow ✅ No linter error ✅ README is okay ✅ The project is working 👍 ✅ Good PR description 👍

Required Changes ♻️

Check the comments under the review.

Cheers and Happy coding!👏👏👏

Olivier-Kango commented 2 years ago

[ ] We noticed that in the README.md file, the live demo link doesn't display the expected page. Kindly try to put /dist at the end of the Link. https://nejjari001.github.io/To-Do-List-List-structure/dist,
[ ] Every time when we reload the page, it displays other items apart from what it should typically show... I suggest verifying the local Storage feature. Maybe data are not stored correctly.

Nejjari001 commented 2 years ago

Hi @Olivier-Kango, thanks for the review. I will make sure to implement those required changes. Cheers 😃

Olivier-Kango commented 2 years ago

Thank you Bro, Cheers 🤝