stgeke
commented
7 years ago Yes let's ignore them for now. I will look at it.
On 28 Apr 2017, at 13:31, Ron Rahaman <notifications@github.com mailto:notifications@github.com > wrote:
This PR addresses #2
It runs the original test programs included with gslib. The tests are considered successful if the programs exit with exit code 0.
Two of the tests are currently failing:
- gs_test_old
- findpts_el_2_test2
It's unclear to me why they fail or whether they are expected failures. Should we ignore or exclude them for now?
You can view, comment on, or merge this pull request online at:
https://github.com/gslib/gslib/pull/6
Commit Summary
- Fixed/cleaned-up Makefiles for make tests
- Added .travis.yml
- Added -lm to Makefile, for compilers that need it
- Specified np=3 for xxt_test
- Allow failures for gs_test_old, findpts_el_2_test2
- Corrected accept fail: gs_test --> gs_test_old
File Changes
- A .travis.yml (45)
- M src/Makefile (94)
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
RonRahaman
This PR addresses #2
It runs the original test programs included with gslib. The tests are considered successful if the programs exit with exit code 0.
Two of the tests are currently failing:
It's unclear to me why they fail or whether they are expected failures. Should we ignore or exclude them for now?