search

Nek5000 / nekRS

our next generation fast and scalable CFD code
https://nek5000.mcs.anl.gov/
Other
269 stars 71 forks source link

Re-add mesh_t::NboundaryFaces #424

Closed aprilnovak closed 2 years ago

aprilnovak commented 2 years ago

Cardinal relies upon this data member, which was deleted in the latest next update. This is much simpler for us than recomputing it.

MalachiTimothyPhillips commented 2 years ago

Cardinal relies upon this data member, which was deleted in the latest next update. This is much simpler for us than recomputing it.

I don't think we want to keep this data member around. Thoughts @stgeke ?

aprilnovak commented 2 years ago

Is there a downside to having it? It would be much more convenient for us to have it available.

MalachiTimothyPhillips commented 2 years ago

Is there a downside to having it? It would be much more convenient for us to have it available.

Fair enough. We'll go ahead and merge your PR into our internal development version. Thank you for your contribution!

aprilnovak commented 2 years ago

Thank you! 👍 Appreciate the flexibility.