search

Nek5000 / nekRS

our next generation fast and scalable CFD code
https://nek5000.mcs.anl.gov/
Other
284 stars 75 forks source link

External HYPRE #425

Closed aprilnovak closed 2 years ago

aprilnovak commented 2 years ago

I think these are the changes needed to use an external HYPRE. I'm doing some further testing to make sure, but wanted to put this here to discuss.

stgeke commented 2 years ago

Can you please confirm that this works as expected using the latest next branch?

aprilnovak commented 2 years ago

It doesn't work yet - I am still trying to figure out why it does not work fully.

aprilnovak commented 2 years ago

Through some very good luck, I actually think this works now - I think I stumbled on the correct CMake command to get things to work for me.

Full disclaimer: I am not an expert in CMake. These changes work for us, but I'm not well versed in what impacts this could have on NekRS by itself. I think the impact is zero because standalone NekRS should never have HYPRE_DIR defined externally.

stgeke commented 2 years ago

Fixed in https://github.com/Nek5000/nekRS/commit/9ae887200454a3409e8a0c324bde9989815716c3