Nek5000 / nekRS

our next generation fast and scalable CFD code
https://nek5000.mcs.anl.gov/
Other
284 stars 75 forks source link

warning for periodic BCs in par #502

Open dshaver-ANL opened 1 year ago

dshaver-ANL commented 1 year ago

Describe the bug The code does not throw an error when trying to set periodic BC in the .par file. A user may have a mesh where they have non-zero periodic BoundaryIDs (as with the wirehexmesher) and incorrectly try to set them in the par file. We should warn them when they try.

To Reproduce include the following in a par file for a mesh with BCids 1, 2, 3, and 4 [VELOCITY] boundaryTypeMap = wall, wall, periodic, periodic

Expected behavior Is there any scenario where periodic BCs can or should be set in the par file? If not, we should catch this as an invalid BC choice.

Desktop (please complete the following information):

Additional context The code will echo this back

================ ELLIPTIC SETUP VELOCITY ================
bID 1 -> bcType zeroValue
bID 2 -> bcType zeroValue
bID 3 -> bcType periodic
bID 4 -> bcType periodic

which would imply this is the correct way to set the BC.