search

NekR / offline-plugin

Offline plugin (ServiceWorker, AppCache) for webpack (https://webpack.js.org/)
MIT License
4.52k stars 295 forks source link

Default autoUpdate to true #396

Open mxstbr opened 6 years ago

mxstbr commented 6 years ago

Not sure when you'd ever want your ServiceWorker to not update ever? That seems like the way less common case than updating on change.

GGAlanSmithee commented 6 years ago

@mxstbr

Thanks for this, makes sense too me. Corresponding docs needs to be updated too.

BTW - is true (= 1 hour) the most reasonable default, or should we have a slightly longer default, say 10 hours or something like that?

@NekR does this update make sense to you?

mxstbr commented 6 years ago

BTW - is true (= 1 hour) the most reasonable default, or should we have a slightly longer default, say 10 hours or something like that?

I think it should be shorter, if anything?

GGAlanSmithee commented 6 years ago

@mxstbr yeah, was thinking it might be a large change going from never auto-updating to once an hour as a default, but I agree it makes more sense to have it be shorter.

NekR commented 5 years ago

Hey guys. Sorry for a delay. autoUpdate was I intentionally not enabled by default because there were reasonable complaints about having an always running timer and not knowing about it.

But I found a solution which allows to perform autoUpdate directly from SW and without timers. I'll hope get to work on it soon.

Meanwhile, I'm working on improving community around offline-plugin plugin, going to Spectrum with it, etc. Stay tuned ;-)

пн, 30 июл. 2018 г., 11:53 Alan Smithee notifications@github.com:

@mxstbr https://github.com/mxstbr yeah, was thinking it might be a large change going from never auto-updating to once an hour as a default, but I agree it makes more sense to have it be shorter.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NekR/offline-plugin/pull/396#issuecomment-408793892, or mute the thread https://github.com/notifications/unsubscribe-auth/ABIlkQt4OmpSC60J5j3DzrOsLA3deoOFks5uLsmRgaJpZM4U5V7f .