search

NekR / offline-plugin

Offline plugin (ServiceWorker, AppCache) for webpack (https://webpack.js.org/)
MIT License
4.52k stars 295 forks source link

getRegistration Scope #439

Closed lilfolr closed 5 years ago

lilfolr commented 5 years ago

I haven't tested this with our site yet (will do this week), but I'll submit the PR anyway for review Fix #435

GGAlanSmithee commented 5 years ago

@lilfolr thanks for this. Please do test with your site, also, if possible, test without using the scope for backward compatability.

GGAlanSmithee commented 5 years ago

@lilfolr #436 was merged into master, so if you merge latest master into your branch, and remove the unrelated code according to my comments, the CI would probably pass

lilfolr commented 5 years ago

Awesome will do - I'll merge & make the changes tomorrow night

GGAlanSmithee commented 5 years ago

@lilfolr thanks for the additional changes. Did you have a chance to test your changes?

lilfolr commented 5 years ago

Sorry, haven't had a chance yet - but will do soon!

lilfolr commented 5 years ago

Have tested with & without the scope option and it looks ok to me

GGAlanSmithee commented 5 years ago

@lilfolr thanks for your contribution! Sorry for the delay, been very busy lately.