NekR / offline-plugin

Offline plugin (ServiceWorker, AppCache) for webpack (https://webpack.js.org/)
MIT License
4.52k stars 294 forks source link

Problem with Webpack 5.0 #491

Open sergeushenecz opened 4 years ago

sergeushenecz commented 4 years ago

Hello everyone. I have some problem when i updating from webpack 4 to 5 version. When i build project i have error in the console.

image

Error in line code. image

Enase commented 4 years ago

the same issue for me. Some more details: result.resource is undefined. It can be accessed at result.createData.resource but then the following:

Uncaught exception: Error: NormalModuleFactory.afterResolve is no longer a waterfall hook, but a bailing hook instead. Do not return the passed object, but modify it instead. Returning false will ignore the request and results in no module created.
sergeushenecz commented 4 years ago

@Enase I found an issue https://github.com/webpack/webpack/issues/11647 The same problem. I think plugin not supported the new version webpack.

Enase commented 4 years ago

@sergeu90 ic, it's true. thanks.

sergeushenecz commented 4 years ago

@NekR Hello. Are we planning to upgrade to webpack 5?

sergeushenecz commented 4 years ago

Can anyone have experience writing a plugin for webpack? Maybe anyone fork and rewrite this library

Enase commented 4 years ago

The last release was done about two years ago. I don't believe that we find any help here.

sergeushenecz commented 4 years ago

Does it mean the plugin is dead? Maybe Are there alternative plugins?

gowrav-scienaptic commented 4 years ago

https://developers.google.com/web/tools/workbox/modules/workbox-webpack-plugin

sergeushenecz commented 4 years ago

@gowrav-scienaptic Can you explain? Is it alternative plugin?

gowrav-scienaptic commented 4 years ago

@sergeu90, Yes it's an alternative for offline-plugin. You can read the details on how to integrate here.

timminata commented 3 years ago

We are using offline-plugin and attempting to upgrade to Webpack 5. Should we wait for this issue to be resolved or is this no longer maintained?

Enase commented 3 years ago

@timminata plugin author doesn't reply over two years. Unfortunately, the answer is yes.

sergeushenecz commented 3 years ago

@gowrav-scienaptic Thanks. I migrated to workbox.

LeComptoirDesPharmacies commented 3 years ago

Hello guys ! Our team needs offline-plugin to work with Webpack 5, so we worked on a fix here : https://github.com/NekR/offline-plugin/pull/498

Enjoy :) LCDP,

LeComptoirDesPharmacies commented 3 years ago

Hello again guys ! Our team forked and worked on a relase candidate that work with Webpack 5, it's available here => https://www.npmjs.com/package/@lcdp/offline-plugin

Any feedback are welcome, we need you to improve the compatibility with webpack 5 !

Enase commented 3 years ago

@LeComptoirDesPharmacies Unfortunately it's not possible to create issue in your github repo. There is an issue while webpack build with your implementation:

(node:18736) [DEP_WEBPACK_COMPILATION_CACHE] DeprecationWarning: Compilation.cache was removed in favor of Compilation.getCache()
    at compilationFn (......./node_modules/@lcdp/offline-plugin/lib/service-worker.js:142:25)
    at _next36 (eval at create (......../node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:50:1)
    at _next14 (eval at create (......../node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:97:1)

and

BREAKING CHANGE: No more changes should happen to Compilation.assets after sealing the Compilation.
    Do changes to assets earlier, e. g. in Compilation.hooks.processAssets.
    Make sure to select an appropriate stage from Compilation.PROCESS_ASSETS_STAGE_*.
    at ServiceWorker.apply (....../node_modules/@lcdp/offline-plugin/lib/service-worker.js:192:35)
LeComptoirDesPharmacies commented 3 years ago

@Enase Sorry for this, we have enabled the issues on our repo.

Thank you for your feedback, as we use webpack 5 in production we should fix this depreciation warning before it becomes really breaking.

Do it break your build ?

We have the same warning, but everything works like a charm.

If you see others warnings, don't hesitate to open an issue on our repo, know it's working 💯

Yours faithfully, LCDP