search

NekR / offline-plugin

Offline plugin (ServiceWorker, AppCache) for webpack (https://webpack.js.org/)
MIT License
4.52k stars 295 forks source link

`onInstalling` doesn't seem to be called, because `ignoreInstalling` is always true #495

Open julienw opened 3 years ago

julienw commented 3 years ago

Hey! Thanks for this great package.

I noticed that onInstalling isn't called, it looks like ignoreInstalling is set to true and then never changed. See https://github.com/NekR/offline-plugin/blob/2b51a89aba53fcf1603786f86a75e6f25fd03721/tpls/runtime-template.js#L56

Is there a way to set this to false or am I missing something?

Happy to provide a patch with some rough guidance about what to do here.