fix: Rev @crxjs/vite-plugin to properly include side_panel(s)

NekitCorp / chrome-extension-svelte-typescript-boilerplate

Boilerplate for Chrome Extension Svelte Typescript project

237 stars 50 forks source link

fix: Rev @crxjs/vite-plugin to properly include side_panel(s) #19

Closed idearat closed 1 year ago

idearat commented 1 year ago

The current version of this template predates the addition of side_panel support to the @crxjs/vite-plugin. Adjusting the version to the latest beta (18) fixes this and allows builds to properly include side_panel content.

NekitCorp commented 1 year ago

Hello, thank you very much for your contribution!

Everything looks good to me, except for one thing. Could you also add the content of the package-lock.json file after updating the package? Because it is in it that the version of the package is explicitly fixed.

idearat commented 1 year ago

Actually I realized that just updating package*.json would only be half the solution. So I've updated the PR with the sample side_panel implementation I used to verify it all works. Hope this is helpful!