Renaming Suggestion of Method Names to Make Them More Descriptive
Description
We have developed a tool (NameSpotter) for identifying non-descriptive method names, and using this tool we find a non-descriptive method name in your repository:
/* Non-descriptive Method Name in src/main/java/net/minecraft/server/management/ServerConfigurationManager.java*/
public void sendMessageToTeamOrEvryPlayer(EntityPlayer player, IChatComponent message)
{
Team team = player.getTeam();
if (team == null)
{
this.sendChatMsg(message);
}
else
{
for (int i = 0; i < this.playerEntityList.size(); ++i)
{
EntityPlayerMP entityplayermp = (EntityPlayerMP)this.playerEntityList.get(i);
if (entityplayermp.getTeam() != team)
{
entityplayermp.addChatMessage(message);
}
}
}
}
We consider "sendMessageToTeamOrEvryPlayer" as non-descriptive because it contains a typo, i.e., "Evry" should be "Every".
We have corrected them (including all the occurrences in other file) and submitted a pull request.
Do you agree with the judgment?
If not, could you please leave your valuable opinion?
If you do agree, the relevant modification has been submitted as a PR, and thanks for your precious time to consider it.
Renaming Suggestion of Method Names to Make Them More Descriptive
Description
We have developed a tool (NameSpotter) for identifying non-descriptive method names, and using this tool we find a non-descriptive method name in your repository:
We consider "sendMessageToTeamOrEvryPlayer" as non-descriptive because it contains a typo, i.e., "Evry" should be "Every".
We have corrected them (including all the occurrences in other file) and submitted a pull request.
Do you agree with the judgment?
If not, could you please leave your valuable opinion?
If you do agree, the relevant modification has been submitted as a PR, and thanks for your precious time to consider it.