Closed bachya closed 6 years ago
Merging #77 into develop will decrease coverage by
0.23%
. The diff coverage is0%
.
@@ Coverage Diff @@
## develop #77 +/- ##
===========================================
- Coverage 95.2% 94.96% -0.24%
===========================================
Files 19 19
Lines 1188 1191 +3
===========================================
Hits 1131 1131
- Misses 57 60 +3
Impacted Files | Coverage Δ | |
---|---|---|
amazon_dash/config.py | 84.12% <0%> (-4.21%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ca2829a...365c8f0. Read the comment docs.
Everything seems to be correct :+1: I have to check that it works on my machine and will be included in Amazon-dash 1.2.0.
Do you want to be added to the contributors section?
@Nekmo Happy to join as a contributor! I can help with the Docker Hub stuff that way, too.
@bachya It's done. Thank you :)
@Nekmo If you'd like me to manage the Docker Hub stuff, you'll either need me to make me a co-owner of this repo or set up the Docker Hub repo and make me a co-owner there.
This PR adds support for hosting and running Amazon Dash within a Docker container (#61).
Below are instructions on how to correctly host a Docker image on Docker Hub going forward.
Set up Docker
Set up a Docker Hub Repo
Create an Automated Build Process
At the Docker Hub website:
nekmo/amazon-dash
repo.Branch
–master
–/
–latest
Tag
–<EMPTY>
–/
–<Same as tag>
Push As Normal
With the above rules, the following will occur anytime you push:
master
will trigger a Docker build to thelatest
tag.Feel free to add me as a collaborator to this Docker repo; happy to help you maintain while you get your feet under you!
Lastly, I think the docs are sufficient and correct, but let me know if more is needed.