Closed s0i37 closed 3 years ago
Hi @s0i37 ,
Thanks for your contribution! I just found a mistake. In Python you should not use dynamic values in parameters. Here is more info:
https://codefellows.github.io/sea-f2-python-sept14/session05.html#mutables-as-default-arguments
After this error I could include your changes. It would also be great if you include tests.
Thanks again!
I have fixed
Merged! Thank
Codecov Report
98.03% <77.77%> (-0.92%)
84.12% <100.00%> (ø)
90.42% <0.00%> (+0.70%)
100.00% <0.00%> (+1.25%)
100.00% <0.00%> (+1.28%)
100.00% <0.00%> (+6.66%)
79.16% <0.00%> (+29.16%)
Continue to review full report at Codecov.