search

Nekroze / dab

The Developer Laboratory
https://nekroze.github.io/dab
GNU General Public License v3.0
7 stars 17 forks source link

Improve Automated Code Review #323

Open Nekroze opened 5 years ago

Nekroze commented 5 years ago

Change Request

Please describe the current behaviour

At present dab uses DangerJS in CI to do some basic checks on a PR to give some automated feedback.

What is suboptimal about the current behaviour

The current behaviour is insufficient because it only has a few simple checks and some of them do not appear to be working.

Describe the way you think it should behave

Codify existing rules for changes such as a new app being added (just takes a new docker-compose file) must be accompanied by a change to the apps completion file to list it there, etc.

Nekroze commented 5 years ago

Assigned myself as most of these rules are just in my head for now.

Nekroze commented 5 years ago

needs to ensure PR's are not empty nor just the default template unaltered as well