sscanf(...) is not compatible with MSVC 2019 compiler

Nelarius / imnodes

A small, dependency-free node editor for dear imgui

MIT License

1.97k stars 241 forks source link

sscanf(...) is not compatible with MSVC 2019 compiler #131

Closed EssenOH closed 2 years ago

EssenOH commented 2 years ago

The compiler recommends you use sscanf_s(...)

Green-Sky commented 2 years ago

The _s subset of functions is non standard in c++.

EssenOH commented 2 years ago

Ya, that's why I reported it because MSVC 2019 returns error with standard API and recommend non standard way. it brings up that you need a consideration to keep a single file for different compilers. otherwise, it relies on user for the modification responsibility to different compiler.

Green-Sky commented 2 years ago

We could add defines like ImGui. I assume that ImGui compiles for you?