search

Nelarius / imnodes

A small, dependency-free node editor for dear imgui
MIT License
1.94k stars 237 forks source link

SWPBL-190575 -- get IP address from user input #162

Closed jehan-diaz closed 1 year ago

jehan-diaz commented 1 year ago

OVERVIEW We now require the user to input a valid IP address (which has already been authenticated) before deploying to that player.

TO TEST Create a system, save it, and run through the validate, generate, and deploy commands. Check the generated system.json file against the configDSP page for your player. Enjoy. Run clean afterwards if you so wish.

NOTES

  1. Known issue : I think the validate command won't run and log anything to the terminal if you don't enter param values on an otherwise valid system.
  2. Make sure to check the terminal to verify that the commands did in fact run! The logger will be implemented in a different story.
  3. Because of my weird experience with squash n merge, this PR now has a lot of commits under it :(