NelleV / moanin

Timecourse transcriptomic analysis
https://nellev.github.io/moanin/
Other
5 stars 0 forks source link

Should fit_predict_splines be an internal function? #34

Closed epurdom closed 4 years ago

epurdom commented 4 years ago

I am trying to write documentation for fit_predict_splines, and it seems like this could use a keywords internal. But perhaps I am not clear on the usage here. Maybe also fit_splines? Not clear how much we expect the user to be using these functions...

Perhaps it would be better if DE_timecourse gave the option to return the results of the fit_splines and then fit_splines would be internal? Would this make it faster to run the clustering downstream?