search

NelleV / moanin

Timecourse transcriptomic analysis
https://nellev.github.io/moanin/
Other
5 stars 0 forks source link

Shouldn't have `set.seed` in function call #51

Closed epurdom closed 4 years ago

epurdom commented 4 years ago

It's not generally considered good coding practice to call set.seed inside a function as we do in splines_kmeans (user is expected to set it before calling function). This gives a warning by BiocCheck

epurdom commented 4 years ago

However, we are calling a function from ClusterR which does just that. This may have to be something we explain to reviewers. I updated the documentation to emphasize that this an argument passed to ClusterR so clear not something we dreamed up.

NelleV commented 4 years ago

I don't know if it matters, but this call to set.seed was only done if the user passed the random seed argument to the function.

epurdom commented 4 years ago

I think when we submit, we are suppose to explain any NOTES remaining in BiocCheck and we can explain that one given that is how ClusterR set it up, not us.