search

NelloKudo / osu-winello

osu! stable installer for Linux with patched wine-osu and other nice features 8)
GNU General Public License v3.0
297 stars 13 forks source link

osu-winello.sh | W10Fonts invalid variable #44

Closed JustRoxy closed 10 months ago

JustRoxy commented 10 months ago

https://github.com/NelloKudo/osu-winello/blob/main/osu-winello.sh#L998-L1001

    if [ "$fontsch" = 1 ] || [ "$fontsch" = 2 ] ; then  
    case "$installpath" in

    '1')

$installpath is not defined in the scope, causing function to exit with no logic executed on valid inputs.

NelloKudo commented 10 months ago

Oh you’re actually right on this lmao, I probably just copied the case function from ConfigurePath when I rewrote the script and ended up not changing $installpath with $fontsch. Gonna fix that in next commit, thanks for noticing!! 😭