search

NelloKudo / osu-winello

osu! stable installer for Linux with patched wine-osu and other nice features 8)
GNU General Public License v3.0
297 stars 13 forks source link

Editor timing panel glitchiness #86

Closed Luminiscental closed 2 weeks ago

Luminiscental commented 3 weeks ago

With a fresh install of winello and WINE_DISABLE_GLCHILD_HACK=1, I get that the timing panel in the editor has weird visual artifacts (screenshot below) and also half the time the buttons are uninteractable (maybe uninteractable until re-selecting a green line on the right? haven't tested much).

FWIW I'm on arch with i3wm, which I'm aware can cause some jankiness with popup windows like this, but re-switching focus, resizing e.t.c. doesn't make any difference for me here.

Screenshot_2024-08-16_22-11

VelamyGH commented 3 weeks ago

same issues on my end as well, able to reproduce on arch (specifically on KDE and x11)

i've also had a lot more editor issues than this, but ill show everything on my end here;

NelloKudo commented 3 weeks ago

same issues on my end as well, able to reproduce on arch (specifically on KDE and x11)

i've also had a lot more editor issues than this, but ill show everything on my end here;

  • File, Edit, and View buttons not showing: image
  • Timing panel glitchiness (this appears to mostly fix itself after tabbing out and back in? not 100% sure on this): image
  • Stat change numbers not showing on the adjustments sliders (makes it just completely unable to tell what number i'm setting, especially for decimal values): image image

Some of those issues you mentioned are fixed by setting WINE_DISABLE_GLCHILD_HACK=1 in ~/.local/bin/osu-wine

The timing panel issues is probably due to some change in Wine we haven’t investigated yet, we’ll get there eventually but trying out the other Wine releases in WineBuilder might fix it.

Luminiscental commented 3 weeks ago

Notes:

I tested:

Also the scroll reset issue when clicking on the timing point list isn't present in wine-osu-stable 7.16, but is present from wine-osu-tkg 9.0-rc1-v2 onwards, so I guess some regression happened there

So yeah for mapping I get the best results with wine-osu-stable 7.16, since it doesn't have these visual artifacts, it doesn't have the scroll reset issue, and it also doesn't have broken stat change tooltips. The only editor issues I encounter with it are popups disabling fullscreen and not gaining focus, meaning e.g. Song Setup can't be interacted with without first refocusing it. There might be more recent versions which are also good since I didn't test that much

whrvt commented 3 weeks ago

Let me know if you still experience this problem with this build (still with WINE_DISABLE_GLCHILD_HACK=1):

https://github.com/whrvt/WineBuilder/releases/tag/v9.15-editor-testing

edit: accidentally uploaded the wrong binary

Luminiscental commented 3 weeks ago

Let me know if you still experience this problem with this build (still with WINE_DISABLE_GLCHILD_HACK=1):

https://github.com/whrvt/WineBuilder/releases/tag/v9.15-editor-testing

edit: accidentally uploaded the wrong binary

This build fixes all the issues I encountered!

NelloKudo commented 3 weeks ago

spectator cooking as usual 🍷

releasing a new build as soon as I have a working setup!

Luminiscental commented 3 weeks ago

Ok actually there is one issue with that 9.15 build; the rotate dialogue no longer opens with the angle selected for replacement, so instead of just ctrl+shift+R, 5 to rotate by 5 degrees I have to do ctrl+shift+r, select textbox, 5

(Also weirdly buttons on the timing panel can sometimes have like multiple seconds of delay, or not trigger at all, but this stops happening after toggling fullscreen on/off)

whrvt commented 3 weeks ago

the rotate dialogue no longer opens with the angle selected for replacement

I never would have even realized that was a problem, because I don't have any muscle memory in the editor. If this build fixes the issue for you (it works for me on a clean prefix), we should be able to make a stable release in the next few days. https://github.com/whrvt/WineBuilder/releases/tag/v9.15-editor-testing-2

Luminiscental commented 2 weeks ago

the rotate dialogue no longer opens with the angle selected for replacement

I never would have even realized that was a problem, because I don't have any muscle memory in the editor. If this build fixes the issue for you (it works for me on a clean prefix), we should be able to make a stable release in the next few days. https://github.com/whrvt/WineBuilder/releases/tag/v9.15-editor-testing-2

This fixes the rotate dialogue for me!

NelloKudo commented 2 weeks ago

Closing this once I release the build then! Thanks everyone for the help, debugging editor is nothing but pain 🥲

im hopefully releasing soon, almost done with vacation!