search

NemProject / NanoWallet

👛
287 stars 13 forks source link

Please don't use "2.4.7" in the next release. #611

Closed jabo38 closed 3 years ago

jabo38 commented 3 years ago

For clarity, each release should have a different number. For instance I have a version 2.4.7 where I can make votes and a version 2.4.7-optin where I can't.

If we are going to tag "optin" in the name, I think it should at least be "2.4.8-optin" or later.

QuantumMechanics commented 3 years ago

I did not had time to review the opt-in changes and the pull request has been merged with an old version of the voting module.

I would like to release a version 2.4.8 with a fix but the pull added private dependencies to the packages.json file and it prevent me from doing any build as mentioned in issue #610

Not sure why this has been allowed, merges must not be blocking in any way, anyone should be able to build the project and review dependencies :/

Is it possible to contact the owner of the dependencies to make them public or give me access ?

cryptoBeliever commented 3 years ago

@QuantumMechanics I asked to contact you via Telegram. If this is not a good way please send me other contact that I should pass :)

QuantumMechanics commented 3 years ago

Telegram is perfect, thank you very much :)

jabo38 commented 3 years ago

@QuantumMechanics thank you for looking into this. I'd suggest there is no reason to have "optin" after the release number personally. It isn't like in the years to come that would still need to be in there.

QuantumMechanics commented 3 years ago

I agree, will remove the "optin" tag in next release.

rg911 commented 3 years ago

Telegram is perfect, thank you very much :)

Hi @QuantumMechanics would be good to connect you on telegram as well, already sent you a message, my username is @rg911